Suppress method redefinition warnings #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When running with `$VERBOSE` set to `true`, rspectre generates a very large # of method redefinition warnings. We can suppress those by removing the method before redefining it. This is very slightly less performant but I think it's worth it. - Also enforces that we have no STDERR output in CI. Required slightly modifying a couple of spec examples that triggered warnings.
dgollahon
force-pushed
the
suppress-method-redefinition-warnings
branch
from
66c4a17
to
fd1c128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$VERBOSEset totrue, rspectre generates a very large # of method redefinition warnings. We can suppress those by removing the method before redefining it. This is very slightly less performant but I think it's worth it.