Enable GnuPG signed tags #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
|
Looks like the tests don't like the fallback keyword, but I don't know why. That's valid with py3. Are some of the tests using py2 maybe? |
|
Yes quite likely, tito still needs to run on RHEL 7 at the very least and I don't think that's available in the base repos. |
bcl
force-pushed
the
master-signed-tags
branch
from
1c3bc43
to
dd935be
Compare
Add 'sign_tag = 1' to the [buildconfig] section of tito.props to enable it.
|
Rebased onto current master, looks like the tests pass when I run them locally. |
|
/lgtm |
|
No bot here @jmrodri :) Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'sign_tag = 1' to the [buildconfig] section of tito.props to enable it.