Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate local version of modernizr.js #3

Open
bittner opened this issue Mar 5, 2017 · 0 comments
Open

Integrate local version of modernizr.js #3

bittner opened this issue Mar 5, 2017 · 0 comments

Comments

@bittner
Copy link

bittner commented Mar 5, 2017

It would be nice if the two files modernizr.js and modernizr-min.js were shipped with this package in case people preferred to distribute resources from their own server. (Resolving a not yet known host name can result in an enormous performance impact, especially noticeable on single-page apps.)

The current version of those files can be downloaded from https://modernizr.com/download

Convenience

Of course, strictly speaking this is not necessary. Any project could simply download the JavaScript file, add it to its own set of static files, and set the MODERNIZR_JS_URL option in the settings. - It would be convenient, though. Django developers could then easily include the Modernizr JavaScript in their own project templates:

{% load static %}
...
<script src="{% static 'modernizr/modernizr-min.js' %}"></script>
</body>
</html>

Side note: We do a similar thing in django-bootstrap-static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant