Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation in README #73

Closed
manishrjain opened this issue Jun 26, 2017 · 0 comments
Closed

Add documentation in README #73

manishrjain opened this issue Jun 26, 2017 · 0 comments
Assignees
@MichaelJCompton
Labels
kind/enhancement Something could be better.

Comments

@manishrjain
Copy link
Contributor

I think it would be good to have BoltDB style documentation in the README of Badger. We have docs in godocs, so can use that for reference.
@manishrjain manishrjain added the kind/enhancement Something could be better. label Jun 26, 2017
ngaut pushed a commit to ngaut/badger that referenced this issue Feb 28, 2019
@coocood
change compaction filter func to factory and return 3 decisions. (dgr…
227bb01 
…aph-io#73)

- Change to factory
We need to access safePoint atomically during compaction.
Using A factory to create compaction filter can avoid atomic operation in Filter method.

- Filter method returns 3 decisions
Sometimes we need to convert the entry into a tombstone to prevent old version appear again, some times we need to simply drop the entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelJCompton MichaelJCompton

Labels
kind/enhancement Something could be better.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manishrjain @MichaelJCompton