release/v2.2007 Fix integer overflow on 32-bit architectures #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
|
|
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
| @@ -47,7 +47,7 @@ import ( | |||
|
|
|||
| // maxVlogFileSize is the maximum size of the vlog file which can be created. Vlog Offset is of | |||
| // uint32, so limiting at max uint32. | |||
| var maxVlogFileSize = math.MaxUint32 | |||
| var maxVlogFileSize uint32 = math.MaxUint32 | |||
There was a problem hiding this comment.
Avoid global variables to improve readability and reduce complexity
There was a problem hiding this comment.
Global variable not introduced in this PR, and is still a global variable in master branch. I would keep it as is here.
There was a problem hiding this comment.
We can ignore the comment by codelingo.
jarifibrahim
approved these changes
Oct 12, 2020
|
Thanks @jsoriano |
|
@jsoriano Thanks! You helped me so much. |
|
Hey @g1ibby , we don't have the next patch for v2.2007 planned. Is it possible for you to use the latest release? v3.2011.1? |
|
okay, thank you for the information. I'll be thinking about using v3.* |
korniltsev
added a commit
to korniltsev/phlare
that referenced
this pull request
Jun 5, 2023
cyriltovena
pushed a commit
to grafana/phlare
that referenced
this pull request
Jun 5, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1541, but for v2.2007 branch.
This change is