feat(externalMagic): Introduce external magic number #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
approved these changes
Sep 16, 2021
joshua-goldstein
pushed a commit
that referenced
this pull request
Feb 6, 2023
Badger writes a magic number in the manifest. It helps badger to decide if its current version is compatible with the data on the disk or not. But now the internal data storage of badger is not changed but the data format for dgraph has changed. This causes a problem if someone starts dgraph-2109 on an older dgraph directory. This change adds an external magic number to badger which will help avoid data corruption by causing panic if opening Dgraph on the wrong directory. There are 8 magic bytes in the manifest. Prior to this change: 0-4: magic text 4-8: badgerMagicNumber After this change: 0-4: magic text 4-6: externalMagicNumber 6-8: badgerMagicNumber (cherry picked from commit 2a9a524)
This was referenced Feb 6, 2023
joshua-goldstein
added a commit
that referenced
this pull request
Feb 8, 2023
Badger writes a magic number in the manifest. It helps badger to decide if its current version is compatible with the data on the disk or not. But now the internal data storage of badger is not changed but the data format for dgraph has changed. This causes a problem if someone starts dgraph-2109 on an older dgraph directory. This change adds an external magic number to badger which will help avoid data corruption by causing panic if opening Dgraph on the wrong directory. There are 8 magic bytes in the manifest. Prior to this change: 0-4: magic text 4-8: badgerMagicNumber After this change: 0-4: magic text 4-6: externalMagicNumber 6-8: badgerMagicNumber (cherry picked from commit 2a9a524)
joshua-goldstein
added a commit
that referenced
this pull request
Feb 8, 2023
Badger writes a magic number in the manifest. It helps badger to decide if its current version is compatible with the data on the disk or not. But now the internal data storage of badger is not changed but the data format for dgraph has changed. This causes a problem if someone starts dgraph-2109 on an older dgraph directory. This change adds an external magic number to badger which will help avoid data corruption by causing panic if opening Dgraph on the wrong directory. There are 8 magic bytes in the manifest. Prior to this change: 0-4: magic text 4-8: badgerMagicNumber After this change: 0-4: magic text 4-6: externalMagicNumber 6-8: badgerMagicNumber (cherry picked from commit 2a9a524)
mangalaman93
pushed a commit
that referenced
this pull request
Feb 9, 2023
mangalaman93
pushed a commit
to dgraph-io/dgraph
that referenced
this pull request
Feb 9, 2023
Update dep on Badger to include dgraph-io/badger#1745
mangalaman93
pushed a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, badger writes a magic number in the manifest. It helps badger to decide if its current version is compatible with the data on the disk or not. But now the internal data storage of badger is not changed but the data format for dgraph has changed. This causes a problem if someone starts dgraph-2109 on an older dgraph directory. This change adds an external magic number to badger which will help avoid data corruption by causing panic if opening Dgraph on the wrong directory.
There are 8 magic bytes in the manifest.
Prior to this change:
After this change:
This change is