New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update metrics in badger #1948

Merged

mangalaman93 merged 23 commits into main from harshil/change_metric_name

Jul 18, 2023

Contributor

harshil-goel commented May 12, 2023

Problem

Our current metrics are outdated, and some of them are not being invoked at all right now.

Solution

Added new metrics, and fixed old ones.

Harshil Goel added 3 commits

May 10, 2023 04:39


          updated v3 to v4 in badger metrics

6cc0a4c


          updated comments about metrics

64169d0


          added and fixed some metrics

41460c1

harshil-goel requested review from akon-dey, billprovince, joshua-goldstein and skrdgraph as code owners

May 12, 2023 08:46

Harshil Goel added 4 commits

May 12, 2023 23:45


          fixed build issue


          added some metrics

2bce757


          added logs for key ranges

66fdd81


          fixed typo

b65f4d9

harshil-goel commented

View reviewed changes

y/metrics.go Show resolved Hide resolved

y/metrics.go Outdated Show resolved Hide resolved

y/metrics.go Show resolved Hide resolved

Harshil Goel added 4 commits

May 27, 2023 04:03


          commit bench file

6b69983


          Checking potential bug fix

d4f9792


          temp

7289ab5


          added a metric test

4b4b674

damonfeldman reviewed

View reviewed changes

damonfeldman left a comment

This looks like very important work, both extending and fixing existing metrics.

I don't read golang very well, so my comments may be off target, but thought it best to ask.

db.go Show resolved Hide resolved

db.go Show resolved Hide resolved

levels.go Show resolved Hide resolved

memtable.go Outdated Show resolved Hide resolved

nswamy reviewed

View reviewed changes

y/metrics.go Outdated Show resolved Hide resolved

nswamy reviewed

View reviewed changes

y/metrics.go Show resolved Hide resolved

nswamy reviewed

View reviewed changes

y/metrics.go Outdated Show resolved Hide resolved

nswamy reviewed

View reviewed changes

y/metrics.go Show resolved Hide resolved

nswamy reviewed

View reviewed changes

nswamy left a comment

have a few comments/questions

y/metrics.go Outdated Show resolved Hide resolved

db.go Show resolved Hide resolved

levels.go Outdated Show resolved Hide resolved

memtable.go Outdated Show resolved Hide resolved

Harshil Goel added 8 commits

June 19, 2023 10:52


          added more tests

474d58d


          updated things

5f70a8d


          removed bench framwork from this diff

ee5837a


          revereted go.mod and go.sum

9f62427


          updated tests

b690ea8


          Updated comments

4b7877a


          fixed comments

8da863c


          fixed ubild issue

128ef80

mangalaman93 previously approved these changes

View reviewed changes


          fixed lint error

849dc9e

harshil-goel dismissed mangalaman93’s stale review via

849dc9e

July 13, 2023 12:58

mangalaman93 requested changes

View reviewed changes

levels.go Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved


          updated comments

04d57d4

all-seeing-code previously approved these changes

View reviewed changes

mangalaman93 requested changes

View reviewed changes

Contributor

mangalaman93 left a comment

I have some pending questions from last review and added a few more questions around names. I am just trying to figure out whether they are consistent names.

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

metrics_test.go Outdated Show resolved Hide resolved

y/metrics.go Outdated Show resolved Hide resolved


          updated metrics name

a008642

harshil-goel dismissed all-seeing-code’s stale review via

a008642

July 18, 2023 01:24


          Updated metrics name

8fc62b0

mangalaman93 approved these changes

View reviewed changes

mangalaman93 merged commit ec80d3d into main

7 checks passed

mangalaman93 deleted the harshil/change_metric_name branch

July 18, 2023 05:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

damonfeldman damonfeldman left review comments

nswamy nswamy left review comments

mangalaman93 mangalaman93 approved these changes

all-seeing-code all-seeing-code left review comments

akon-dey Awaiting requested review from akon-dey

billprovince Awaiting requested review from billprovince

joshua-goldstein Awaiting requested review from joshua-goldstein

skrdgraph Awaiting requested review from skrdgraph