KV parameters verification.

[szymonm]

Resolves #23

---

This change is 

[dolmen]

Use %q instead of '%s'

[dolmen]

Replace should with must as you are handling this as a fatal issue.

[manishrjain]

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

badger/kv.go, line 125 at r1 (raw file):

Previously, dolmen (Olivier Mengué) wrote…

Use %q instead of '%s'

Address the comment above. Also, predefine this error using var, and just reuse them. That way, a user can check the error returned against the var, instead of having to do string matching.

both of these above errors can be ErrInvalidDir.

---

badger/kv.go, line 198 at r1 (raw file):

		return true
	}
	out.vlog.Replay(vptr, fn)

Does Replay return any error? If it can, we should handle it here.

In fact, if you look carefully at all the y.Checkf, you should be able to find the ones which are being directly called from the API. Make all those return errors using errors.Wrapf and the likes. I did that just now for value log opening and closing.

---

Comments from Reviewable

[szymonm]

Review status: 2 of 5 files reviewed at latest revision, 3 unresolved discussions.

---

badger/kv.go, line 125 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Address the comment above. Also, predefine this error using var, and just reuse them. That way, a user can check the error returned against the var, instead of having to do string matching.

both of these above errors can be ErrInvalidDir.

Added type instead of var in order to pass the error message up.
It still can be checked without string matching.

---

badger/kv.go, line 128 at r1 (raw file):

Previously, dolmen (Olivier Mengué) wrote…

Replace should with must as you are handling this as a fatal issue.

Done.

---

badger/kv.go, line 198 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Does Replay return any error? If it can, we should handle it here.

In fact, if you look carefully at all the y.Checkf, you should be able to find the ones which are being directly called from the API. Make all those return errors using errors.Wrapf and the likes. I did that just now for value log opening and closing.

Leaving this for you.

---

Comments from Reviewable

[manishrjain]

one small comment.

---

Reviewed 1 of 3 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

badger/kv.go, line 120 at r3 (raw file):

var ErrInvalidDir error = errors.New("Invalid Dir, directory does not exist")
var ErrInvalidValueLogFileSize error = errors.New("Invalid ValueLogFileSize, must be between 1MB and 1GB")

ErrValueLogSize

---

Comments from Reviewable

[szymonm]

Merged.