test osx in all Go versions, not only the first one #879
Conversation
campoy
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
There was a problem hiding this comment.
I think we don't really look at travis (it's just there because it's what we used before moving to teamcity). Talk to @danielmai about how to do this in teamcity.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
|
Sorry, didn't mean to approve. |
|
In that case, @danielmai can you confirm on what platforms and with which Go versions we're testing our changes? |
|
@campoy In TeamCity the tests run on Linux and Go 1.12.5. In TeamCity it's not so straightforward to configure multi-platform and multi-Go versions on TeamCity. If that's necessary then we can keep Travis around. |
|
We should keep Travis around. Doesn't hurt to run on additional platforms 😀 |
There was a problem hiding this comment.
We should keep Travis around. Doesn't hurt to run on additional platforms 😀
You meant it jokingly. But, actually, it does hurt. The more platforms create noise, the more scattered our focus gets and the more we ignore those signals.
Does Teamcity do the right thing? Can we remove this Travis config if we don't use it? @danielmai
Reviewable status:
We can remove this TravisCI config from Badger. TeamCity tests Badger on Linux and (currently) with Go 1.12.4—we use the go version matching Dgraph release builds. TeamCity also runs other types of tests like a long-running bank-transaction-transfer test overnight and tests with the race detector. |
|
Does TeamCity test Mac and other versions of Go too, @danielmai ? |
|
Right now our TeamCity set up is only Linux and a single version of Go (1.12.4). |
|
OK, in that case I'll close this PR and create a new issue to handle dropping Travis and using only TeamCity but including Windows and MacOS platforms plus go1.11, go1.12, and tip. See PR #888 |
This change is