-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(audit): Update audit-logs.md #289
Conversation
@MichelDiz is there a way to auto-generate these docs from the go project? Also, what was the reasoning for this to get moved to its own repo? ^ I need some clarifications here. |
I think it is possible. But not sure how feaseble. e.g https://pkg.go.dev/search?q=dgraph-io&m= Some packages have these docs generated automatically I think. But those are package. Not sure if it is possible to generate for Dgraph binary.
Really long story. In short the last team(new guys) wasn't happy with Docs inside the main repo. Manish was 100% against the moving, but he capitulated. So the main reason was to deal with docs in a different cycle from the main repository. |
@joshua-goldstein is this Eligible for v22.0.0? Can you pick it to master/main? And later cherry pick it to v22.0.0. |
3d835ea
to
b6a0ef9
Compare
✅ Deploy Preview for dgraph-docs-repo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c046c99
to
02efea1
Compare
02efea1
to
c348883
Compare
PS. @joshua-goldstein now everything new needs to go to Main branch. |
c348883
to
2c824d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
In dgraph/cmd/zero/run.go around L230,
Zero.Conf.GetString("audit")
only parses first subflag.E.g.
dgraph zero --audit output=audit-log-dir;compress=false;encrypt-file=enc-key
is parsed as output=audit-log-dir, omitting the later arguments. I have run into this issue here but it is possibly a more general issue for superflags like alpha, zero, etc. An easy fix is to use quotes:dgraph zero --audit "output=audit-log-dir;compress=false;encrypt-file=enc-key"