Fix warning about issues with the cancel function. (#5397)

The context created with context.WithCancel should be cancelled before jumping to the START label.
dgraph-io · May 8, 2020 · 8db5e1f · 8db5e1f
1 parent 025d14f
commit 8db5e1f
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/worker/groups.go b/worker/groups.go
@@ -787,6 +787,7 @@ START:
 	ctx, cancel := context.WithCancel(context.Background())
 	stream, err := c.StreamMembership(ctx, &api.Payload{})
 	if err != nil {
+		cancel()
 		glog.Errorf("Error while calling update %v\n", err)
 		time.Sleep(time.Second)
 		goto START