fix(GraphQL Query): Remove extra fields when querying interfaces (#6596)

dgraph-io · Sep 30, 2020 · cec5567 · cec5567
1 parent 1d34ade
commit cec5567
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 0 deletions.
diff --git a/graphql/e2e/common/fragment.go b/graphql/e2e/common/fragment.go
@@ -161,6 +161,27 @@ func fragmentInQueryOnInterface(t *testing.T) {
 					id
 				}
 			}
+			qcRep1: queryCharacter {
+				name
+				... on Human {
+					name
+					totalCredits
+				}
+				... on Droid {
+					name
+					primaryFunction
+				}
+			}
+			qcRep2: queryCharacter {
+				... on Human {
+					totalCredits
+				}
+				name
+				... on Droid {
+					primaryFunction
+					name
+				}
+			}
 			queryThing {
 				__typename
 				... on ThingOne {
@@ -269,6 +290,26 @@ func fragmentInQueryOnInterface(t *testing.T) {
 				"id": "%s"
 			}
 		],
+		"qcRep1": [
+            {
+				"name": "Han",
+                "totalCredits": 10
+            },
+            {
+                "name": "R2-D2",
+                "primaryFunction": "Robot"
+            }
+		],
+		"qcRep2": [
+            {
+                "totalCredits": 10,
+                "name": "Han"
+            },
+            {
+                "name": "R2-D2",
+                "primaryFunction": "Robot"
+            }
+		],
 		"queryThing":[
 			{
 				"__typename": "ThingOne",

diff --git a/graphql/resolve/resolver.go b/graphql/resolve/resolver.go
@@ -1268,6 +1268,10 @@ func completeObject(
 	var buf bytes.Buffer
 	comma := ""
 
+	// Below map keeps track of fields which have been seen as part of
+	// interface to avoid double entry in the resulting response
+	seenField := make(map[string]bool)
+
 	x.Check2(buf.WriteRune('{'))
 	dgraphTypes, ok := res["dgraph.type"].([]interface{})
 	for _, f := range fields {
@@ -1285,6 +1289,9 @@ func completeObject(
 		if len(dgraphTypes) > 0 {
 			includeField = f.IncludeInterfaceField(dgraphTypes)
 		}
+		if _, ok := seenField[f.ResponseName()]; ok {
+			includeField = false
+		}
 		if !includeField {
 			continue
 		}
@@ -1294,6 +1301,8 @@ func completeObject(
 		x.Check2(buf.WriteString(f.ResponseName()))
 		x.Check2(buf.WriteString(`": `))
 
+		seenField[f.ResponseName()] = true
+
 		val := res[f.DgraphAlias()]
 		if f.Name() == schema.Typename {
 			// From GraphQL spec: