Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a way to dynamically update the lease #1306

Closed
pawanrawal opened this issue Aug 3, 2017 · 5 comments
Closed

Have a way to dynamically update the lease #1306

pawanrawal opened this issue Aug 3, 2017 · 5 comments
Labels
kind/enhancement Something could be better.

Comments

@pawanrawal
Copy link
Contributor

pawanrawal commented Aug 3, 2017 •
edited by manishrjain

We should be able to update lease information through an admin endpoint similar to #1144.

Dgraphloader should get the lease before starting loading and return an error if the uids being loaded are greater than the lease.
@pawanrawal pawanrawal added the kind/enhancement Something could be better. label Aug 3, 2017
@pawanrawal pawanrawal added this to the v0.8.2 milestone Aug 3, 2017
@pawanrawal pawanrawal modified the milestones: v0.8.3, v0.8.2 Sep 11, 2017
@pawanrawal
Copy link
Contributor Author

pawanrawal commented Oct 4, 2017 •
edited

This is needed before v0.8.3 so that even if users bootstrap dgraph with dgraph-bulk-loader things go smoothly and we don't end up reassigning uids.

@pawanrawal pawanrawal assigned pawanrawal and peterstace and unassigned pawanrawal Oct 4, 2017
@peterstace
Copy link

We won't need this before v0.8.3 due to #1583 , which allows dgraphzero to accept a lease. This still seems like a good feature to have though.

@peterstace peterstace modified the milestones: v0.8.3, v0.8Maybe Oct 4, 2017
@manishrjain
Copy link
Contributor

I think the lease flag is a good solution. We don't need to do anything more at this point.

@peterstace
Copy link

Ok, I think we can park this for now then.

@peterstace peterstace modified the milestones: v0.8Maybe, No Deadline Oct 5, 2017
@peterstace peterstace removed their assignment Oct 5, 2017
@manishrjain
Copy link
Contributor

Closing it for now. We can reopen if we need this again.

jarifibrahim pushed a commit that referenced this issue Apr 22, 2020
Update badger to commit cddf7c03451c (#5216)
7b37ddb 
This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0. 

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314)
fd693e4 Support entry version in Write batch (#1310)
f9332eb Disable go 1.11 builds on travis (#1306)
09dd2e1 Replace EventLog with Logger (#1203)
4f6763c Add leveled logging (#1249)
30eeec2 Update issue template (#1295)
8097259 Proto: make badger/v2 compatible with v1 (#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284)
6e032c0 Fix race condition in DoesNotHave (#1287)
fa94030 Fix Sequence generates duplicate values (#1281)
69f35b3 Add go_package in .proto (#1282)
5f48d42 Disable eventlogging by default (#1285)
4b539b9 Update Project Status in readme.md (#1274)
```
jarifibrahim pushed a commit that referenced this issue Apr 22, 2020
Update badger to commit cddf7c03451c (#5216)
a580d02 
This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0.

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314)
fd693e4 Support entry version in Write batch (#1310)
f9332eb Disable go 1.11 builds on travis (#1306)
09dd2e1 Replace EventLog with Logger (#1203)
4f6763c Add leveled logging (#1249)
30eeec2 Update issue template (#1295)
8097259 Proto: make badger/v2 compatible with v1 (#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284)
6e032c0 Fix race condition in DoesNotHave (#1287)
fa94030 Fix Sequence generates duplicate values (#1281)
69f35b3 Add go_package in .proto (#1282)
5f48d42 Disable eventlogging by default (#1285)
4b539b9 Update Project Status in readme.md (#1274)
```

(cherry picked from commit 7b37ddb)
jarifibrahim pushed a commit that referenced this issue Apr 22, 2020
Update badger to commit cddf7c03451c (#5216)
ee32cf3 
This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0.

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314)
fd693e4 Support entry version in Write batch (#1310)
f9332eb Disable go 1.11 builds on travis (#1306)
09dd2e1 Replace EventLog with Logger (#1203)
4f6763c Add leveled logging (#1249)
30eeec2 Update issue template (#1295)
8097259 Proto: make badger/v2 compatible with v1 (#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284)
6e032c0 Fix race condition in DoesNotHave (#1287)
fa94030 Fix Sequence generates duplicate values (#1281)
69f35b3 Add go_package in .proto (#1282)
5f48d42 Disable eventlogging by default (#1285)
4b539b9 Update Project Status in readme.md (#1274)
```

(cherry picked from commit 7b37ddb)
jarifibrahim pushed a commit that referenced this issue Apr 22, 2020
Update badger to commit cddf7c03451c (#5216) (#5272)
2e0c5ce 
This PR updates badger to the latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0.

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314)
fd693e4 Support entry version in Write batch (#1310)
f9332eb Disable go 1.11 builds on travis (#1306)
09dd2e1 Replace EventLog with Logger (#1203)
4f6763c Add leveled logging (#1249)
30eeec2 Update issue template (#1295)
8097259 Proto: make badger/v2 compatible with v1 (#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284)
6e032c0 Fix race condition in DoesNotHave (#1287)
fa94030 Fix Sequence generates duplicate values (#1281)
69f35b3 Add go_package in .proto (#1282)
5f48d42 Disable eventlogging by default (#1285)
4b539b9 Update Project Status in readme.md (#1274)
```

(cherry picked from commit 7b37ddb)
danielmai pushed a commit that referenced this issue Apr 22, 2020
release/v1.2: Update badger to commit cddf7c03451c33. (#5216) (#5273)
49a8bd3 
* Update badger to commit cddf7c03451c (#5216)

This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0.

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314)
fd693e4 Support entry version in Write batch (#1310)
f9332eb Disable go 1.11 builds on travis (#1306)
09dd2e1 Replace EventLog with Logger (#1203)
4f6763c Add leveled logging (#1249)
30eeec2 Update issue template (#1295)
8097259 Proto: make badger/v2 compatible with v1 (#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284)
6e032c0 Fix race condition in DoesNotHave (#1287)
fa94030 Fix Sequence generates duplicate values (#1281)
69f35b3 Add go_package in .proto (#1282)
5f48d42 Disable eventlogging by default (#1285)
4b539b9 Update Project Status in readme.md (#1274)
```

(cherry picked from commit 7b37ddb)

* Run go mod tidy

* Fix badger options
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 18, 2020
@dna2github
Update badger to commit cddf7c03451c (dgraph-io#5216)
739e27e 
This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .

This PR also changes the following things.
1. Removes the second argument from `watermark.Init()` function. The
second parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
2. go.mod and go.sum updates
3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of
`badgerpb2.KV`. The protobuf package was renamed from `pb` to
`badgr.pb2` dgraph-io/badger@cddf7c0. 

NOTE - I've updated badger using `go get -u ... ` command. All the
changes in go.mod file except badger are a side effect of badger update.

Following new commits are being added from badger
```
git log 91c31ebe8c22...cddf7c03451c --oneline
```
```
cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (dgraph-io#1314)
fd693e4 Support entry version in Write batch (dgraph-io#1310)
f9332eb Disable go 1.11 builds on travis (dgraph-io#1306)
09dd2e1 Replace EventLog with Logger (dgraph-io#1203)
4f6763c Add leveled logging (dgraph-io#1249)
30eeec2 Update issue template (dgraph-io#1295)
8097259 Proto: make badger/v2 compatible with v1 (dgraph-io#1293)
2e708d9 Fail fast if cgo is disabled and compression is ZSTD (dgraph-io#1284)
6e032c0 Fix race condition in DoesNotHave (dgraph-io#1287)
fa94030 Fix Sequence generates duplicate values (dgraph-io#1281)
69f35b3 Add go_package in .proto (dgraph-io#1282)
5f48d42 Disable eventlogging by default (dgraph-io#1285)
4b539b9 Update Project Status in readme.md (dgraph-io#1274)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Something could be better.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manishrjain @peterstace @pawanrawal