Vendor latest badger #3784
Merged
Vendor latest badger #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
|
Looks like it's missing Badger's sub packages, i.e., dgraph-io/badger@88d5a3c made changes to the table package but I don't see any table package changes in this PR. Try with govendor fetch github.com/dgraph-io/badger/... |
|
I don't see the changes we made in builder.go to remove vlen. This commit seems to be missing dgraph-io/badger@88d5a3c |
danielmai
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, 5 of 5 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
danielmai
pushed a commit
that referenced
this pull request
Aug 9, 2019
This change includes the [breaking/format] change dgraph-io/badger@88d5a3c that changes the underlying data format in Badger. (cherry picked from commit e805a16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update badger in dgraph using
govendor fetch github.com/dgraph-io/badger/....This is the Latest Master version of badger.
This change is