Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GraphQL API) Add/UpdateTypePayload use lowercase instead of camelCase for Type field #5380

Closed
CosmicPangolin opened this issue May 6, 2020 · 1 comment · Fixed by #5547
Closed

(GraphQL API) Add/UpdateTypePayload use lowercase instead of camelCase for Type field #5380

CosmicPangolin opened this issue May 6, 2020 · 1 comment · Fixed by #5547
Labels
area/graphql Issues related to GraphQL support on Dgraph. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v20.07.0

Comments

@CosmicPangolin
Copy link

What version of Dgraph are you using?
20.03.1

Have you tried reproducing the issue with the latest release?
Yep

What is the hardware spec (RAM, OS)?
N/A

Steps to reproduce the issue (command/config used to run Dgraph).
N/A

Expected behaviour and actual result.
Currently type-named payload fields are lowercase instead of camelCase. This seems at odds with the rest of the query structure (eg, query/mutation names and other generated fields throughout the schema).

image
@CosmicPangolin CosmicPangolin changed the title (GraphQL API) Add/UpdateTypePayload fields use Type name lowercase instead of camelCase. (GraphQL API) Add/UpdateTypePayload use lowercase instead of camelCase for Type field May 6, 2020
@MichelDiz MichelDiz added the area/graphql Issues related to GraphQL support on Dgraph. label May 8, 2020
@MichaelJCompton
Copy link
Contributor

That's a great catch. Thanks! Looks like we are lower casing the whole type, rather than the first char when we make that.

It'll be a breaking change, so can't go into 20.03.x, would have to go into 20.07.0.

@MichaelJCompton MichaelJCompton added kind/enhancement Something could be better. status/accepted We accept to investigate/work on it. labels May 20, 2020
@MichaelJCompton MichaelJCompton added this to the Dgraph v20.07.0 milestone May 20, 2020
@JatinDev543 JatinDev543 mentioned this issue Jun 2, 2020
Merged
JatinDev543 added a commit that referenced this issue Jun 5, 2020
@JatinDev543 @abhimanyusinghgaur
[Breaking] graphql: Add camelCase for add/update mutation. (#5547)
c5e3f78 
This PR Modify lowercase typename for add/update mutation to camelCase.
Fixes #5380
Fixes #GRAPHQL-448

Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com>
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 18, 2020
@JatinDev543 @abhimanyusinghgaur @dna2github
[Breaking] graphql: Add camelCase for add/update mutation. (dgraph-io…
54710bb 
…#5547)

This PR Modify lowercase typename for add/update mutation to camelCase.
Fixes dgraph-io#5380
Fixes #GRAPHQL-448

Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v20.07.0
Development

Successfully merging a pull request may close this issue.

[Breaking] graphql: Add camelCase for add/update mutation. dgraph-io/dgraph
3 participants
@MichelDiz @MichaelJCompton @CosmicPangolin