Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Ragel for GraphQL Parsing #6

Closed
manishrjain opened this issue Dec 4, 2015 · 1 comment
Closed

Try Ragel for GraphQL Parsing #6

manishrjain opened this issue Dec 4, 2015 · 1 comment
Labels
benchmark
Milestone
v0.2

Comments

@manishrjain
Copy link
Contributor

manishrjain commented Dec 4, 2015 •
edited

And benchmark the performance difference against the current implementation using pure Go. If Ragel performs better, we'd want to switch over sooner, before we build more features on top of existing code.
@manishrjain manishrjain mentioned this issue Dec 5, 2015
Closed
65 tasks
@manishrjain manishrjain added this to the v0.2 milestone Dec 8, 2015
@manishrjain
Copy link
Contributor Author

I had a chance to play with Ragel a bit. I think it would only make for code fragmentation. And it's not clear to me that it would be particularly faster, given the end product would be machine written Go. The current code manually written entirely in Go is pretty understandable, and easy to extend. So, let's stick to that.

I'm closing this issue for now.

janardhan1993 pushed a commit that referenced this issue Jun 26, 2017
@szymonm
Merge pull request #6 from dgraph-io/consistent_copyright
4b16f42 
Deleted duplicated/added copyright info.
danielmai pushed a commit that referenced this issue May 1, 2020
Merge pull request #6 from dgraph-io/latency
78470d3 
Display server and network latency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark
Milestone
v0.2
Development

No branches or pull requests
2 participants
@manishrjain @kunaaljain