feat(cdc): Add support for SCRAM SASL mechanism #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
aman-bansal
approved these changes
Apr 30, 2021
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka. This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512. (cherry picked from commit 8925049)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka. This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512. (cherry picked from commit 8925049)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka. This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512. (cherry picked from commit 8925049)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka. This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512. (cherry picked from commit 8925049)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
ahsanbarkati
added a commit
that referenced
this pull request
Apr 30, 2021
danielmai
added a commit
to dgraph-io/dgraph-docs
that referenced
this pull request
Jul 14, 2021
Documents the new option sasl-mechanism under the kafka superflag. This change was introduced in Dgraph v21.03.1 with PR dgraph-io/dgraph#7765. Example: --kafka="...; sasl-mechanism=SCRAM-SHA-512"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to support only the PLAIN mechanism for SASL in cdc-kafka.
This PR adds support for SCRAM-SHA-256 and SCRAM-SHA-512.
We can specify the mechanism by the
sasl-mechanismsub flag under the--cdcsuperflag.I have tested this change on Amazon MKS.
This change is