Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comments in schema #3133

Merged
merged 5 commits into from Mar 14, 2019
Merged

Support comments in schema #3133

merged 5 commits into from Mar 14, 2019

Commits on Mar 13, 2019

  1. schema/state.go: add comment state to lexer 

    This adds comment detection to lexer. A comment starts with # and ends with
new line or EOF. When new line is detected, it's emitted so the caller can handle it.
If EOF is found, that should end further parsing.
    srfrog committed Mar 13, 2019
    Copy the full SHA
    0b0c4fc View commit details
    Browse the repository at this point in the history

  2. schema/parse_test.go: add test for comments in schema types

    srfrog committed Mar 13, 2019
    Copy the full SHA
    46cb48e View commit details
    Browse the repository at this point in the history

  3. gql/parser.go: fixed typo

    srfrog committed Mar 13, 2019
    Copy the full SHA
    62b9fcf View commit details
    Browse the repository at this point in the history

  4. schema/state.go: rename func lexComment to lexTextComment 

    Package gql has another function called lexComment that works slightly
different to this one, so I renamed this one to avoid confusion.
    srfrog committed Mar 13, 2019
    Copy the full SHA
    4013e89 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' into srfrog/issue-3130_comments_in_schema

    @srfrog
    srfrog committed Mar 14, 2019
    Copy the full SHA
    6c27542 View commit details
    Browse the repository at this point in the history