Make code sequential and remove deadlock #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
suggested changes
Mar 26, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog)
ee/backup/s3_handler.go, line 216 at r1 (raw file):
readManifests := func(objects []string) (map[int]*Manifest, error) { res := make(map[int]*Manifest)
We don't need to read all the manifests. Just the ones until the first full backup.
srfrog
commented
Mar 26, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
ee/backup/s3_handler.go, line 216 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
We don't need to read all the manifests. Just the ones until the first full backup.
We read the manifest to know which files to restore.
added 3 commits
March 26, 2019 16:04
gitlw
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* make code sequential and remove deadlock * simplify code further * worker/backup_ee.go: unwarned change that broke tests after merge * ee/backup/docker-compose.yml: add user to docker compose file to fix testing in Linux * ee/backup/docker-compose.yml: add --cwd to docker service command to fix dir ownership * ee/backup/docker-compose.yml: remove working_dir it interferes with Linux testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is