Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ECDSA in dgraph cert #3269

Merged
merged 12 commits into from
Apr 11, 2019
Merged

Add support for ECDSA in dgraph cert #3269

merged 12 commits into from
Apr 11, 2019

Commits on Apr 8, 2019

  1. cmd/cert/run.go: add EDCSA run option --curve 

    Add short flag -r for RSA bit size. Add flags --curve and -e for EDCSA curve type.
When EDCSA value is set, RSA is ignored.
    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    8cd55d7 View commit details
    Browse the repository at this point in the history

  2. cmd/cert/info.go: support both RSA and EDCSA key types in info

    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    c2214ab View commit details
    Browse the repository at this point in the history

  3. cmd/cert/create.go: change makeKey and readKey for general crypto key… 

    … types

Change signature of readKey and makeKey to support any key type that implements
crypto.PrivateKey. This change is made to add support for EDCSA keys, but in the future
any other type should be simple to add. Note that crypto.PrivateKey is just a plain
dynamic interface type, so it should already support crypto.Signer used in certificate
functions.
    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    f60495a View commit details
    Browse the repository at this point in the history

  4. cmd/cert/cert.go: update to use crypto.Signer

    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    14deab0 View commit details
    Browse the repository at this point in the history

  5. cmd/cert/run.go: rename EDCSA flag to --elliptic-curve to be specific

    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    ca60ea1 View commit details
    Browse the repository at this point in the history

  6. cmd/cert/info.go: add edcsa support to public cert info

    srfrog committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    41a1b25 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/iss… 

    …ue-2642_support_ecdsa_in_dgraph_cert
    srfrog committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    e267e9a View commit details
    Browse the repository at this point in the history

  2. cmd/cert/cert.go: minor changes for code legibility

    srfrog committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    08dea40 View commit details
    Browse the repository at this point in the history

  3. cmd/cert/create.go: minor changes for code legibility and usability

    srfrog committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    07ce93f View commit details
    Browse the repository at this point in the history

  4. cmd/cert/info.go: add encryption type to info output 

    Now that we support different key encryption types, we must display
the name and parameters when displaying its info.
    srfrog committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    3464628 View commit details
    Browse the repository at this point in the history

  5. cmd/cert/run.go: display key enc type in listing info 

    Add a new line to `dgraph cert ls` to display the key encryption type.
Also, don't panic when command parameters fail, simply exit with error code.
    srfrog committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    cc3246a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. cmd/cert/info.go: rename certInfo.encType to 'algo' and display it as… 

    … 'Algorithm' in the listing
    srfrog committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    57b5a0f View commit details
    Browse the repository at this point in the history