release/v1.0: Increase max trace logs per span in Alpha. #3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up the number of logs per span to capture all the events from Server.Query which can create a lot of logs.
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
Code mirrors what the review title/description says and is a good middle point before you can add the other load testing script.
Reviewed with ❤️ by PullRequest
These are already pulled into release/v1.0. Revert "test-bulk-schema: Fix test for non-interactive shell session." This reverts commit 69a68db. Revert "Remove missing 21million test from release/v1.0." This reverts commit beb6b8a. Revert "Reduce required memory." This reverts commit cdb2ee9. Revert "Lower memory requirement for load test." This reverts commit 93afd9f.
I moved the test changes to a separate PR (#3888) to clarify this PR to only this single change. |
gitlw
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pullrequest[bot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #3679 to release/v1.0.
Bump up the number of logs per span to capture more of the events
from Server.Query which can create a lot of trace logs.
This change is