Added C# official client and other minor changes #4568
Conversation
- removed mention of python 2.x - changed mention of Dgraph version from 1.0.x to 1.1.x
There was a problem hiding this comment.
Just one minor comment but otherwise it
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @MichaelJCompton, and @prashant-shahi)
wiki/content/clients/index.md, line 61 at r1 (raw file):
We also have [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples) projects, which contains an working examples of how to use the C# client.
Suggestion for this sentence:
The [example](link to page) page contains working examples of how to use this client.
|
Thanks for working on this! Please do not merge until we are fully ready to declare it officially supported (e.g. until the main child issues of the epic are solved as well) Do we want to have it as first in the list (as it is now) or move it at the bottom (after Python) and keep Go as first client as it is in https://docs.dgraph.io/clients/. Probably this second option? And hey - the preview feature rocks! |
|
Looks fine ... only is is I'd expect that by the time we drop this it'll be supporting Dgraph 1.2.0 |
There was a problem hiding this comment.
@MichaelJCompton I think even if this PR gets merged, it will only be available from docs.dgraph.io/master, and later from main docs if this commit gets picked for the new release.
But yeah, we can wait till the fork is replaced and other required docs are updated.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @martinmr, and @MichaelJCompton)
a discussion (no related file):
@sleto-it I placed it at first to go along with the usual alphabetical ordering.
Your suggestion sounds also right since Go client documentation is more elaborative that other clients cloud relate.
wiki/content/clients/index.md, line 61 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
We also have [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples) projects, which contains an working examples of how to use the C# client.Suggestion for this sentence:
The [example](link to page) page contains working examples of how to use this client.
Done.
…shant/dot-net-client
Signed-off-by: Prashant Shahi <prashant@dgraph.io>
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @danielmai, @martinmr, @MichaelJCompton, and @prashant-shahi)
wiki/content/clients/index.md, line 444 at r3 (raw file):
## C\# The official C# client [can be found here](https://github.com/dgraph-io/Dgraph-dotnet).
url is going to be
https://github.com/dgraph-io/dgraph.net
that'll nee changing for all the urls here
wiki/content/clients/index.md, line 451 at r3 (raw file):
We also have a [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples) page, which contains working examples of how to use the C# client.
I'd say don't include this. There's instructions on the readme in the repo, that's good enough ... and this link won't exist in the end.
Signed-off-by: Prashant Shahi <prashant@dgraph.io>
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @danielmai, @martinmr, and @MichaelJCompton)
wiki/content/clients/index.md, line 444 at r3 (raw file):
Previously, MichaelJCompton (Michael Compton) wrote…
url is going to be
https://github.com/dgraph-io/dgraph.net
that'll nee changing for all the urls here
Done.
wiki/content/clients/index.md, line 451 at r3 (raw file):
Previously, MichaelJCompton (Michael Compton) wrote…
We also have a [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples) page, which contains working examples of how to use the C# client.I'd say don't include this. There's instructions on the readme in the repo, that's good enough ... and this link won't exist in the end.
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @danielmai, @martinmr, and @MichaelJCompton)
Signed-off-by: Prashant Shahi <prashant@dgraph.io>
…shant/dot-net-client
* Added C# official client and other minor changes * addressing comment Signed-off-by: Prashant Shahi <prashant@dgraph.io> (cherry picked from commit 0e90415)
|
Thanks. Needs backport to the 20.03 documentation. |
* Added C# official client and other minor changes * addressing comment Signed-off-by: Prashant Shahi <prashant@dgraph.io> (cherry picked from commit 0e90415)
* Added C# official client and other minor changes * addressing comment Signed-off-by: Prashant Shahi <prashant@dgraph.io> (cherry picked from commit 0e90415)
This change is
Docs Preview: