Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C# official client and other minor changes #4568

Open
wants to merge 2 commits into
base: master
from

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Jan 14, 2020

  • Added C# official client
  • removed mention of python 2.x
  • changed mention of Dgraph version from 1.0.x to 1.1.x

This change is Reviewable

- removed mention of python 2.x
- changed mention of Dgraph version from 1.0.x to 1.1.x
@prashant-shahi prashant-shahi requested a review from MichaelJCompton Jan 14, 2020
@prashant-shahi prashant-shahi requested a review from danielmai as a code owner Jan 14, 2020
Copy link
Member

martinmr left a comment

Just one minor comment but otherwise it :lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @MichaelJCompton, and @prashant-shahi)


wiki/content/clients/index.md, line 61 at r1 (raw file):

We also have [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples)
projects, which contains an working examples of how to use the C# client.

Suggestion for this sentence:

The [example](link to page) page contains working examples of how to use this client.

@sleto-it

This comment has been minimized.

Copy link
Member

sleto-it commented Jan 15, 2020

Thanks for working on this!

Please do not merge until we are fully ready to declare it officially supported (e.g. until the main child issues of the epic are solved as well)

Do we want to have it as first in the list (as it is now) or move it at the bottom (after Python) and keep Go as first client as it is in https://docs.dgraph.io/clients/. Probably this second option?

And hey - the preview feature rocks!

@MichaelJCompton

This comment has been minimized.

Copy link
Member

MichaelJCompton commented Jan 15, 2020

Looks fine ... only is is I'd expect that by the time we drop this it'll be supporting Dgraph 1.2.0

@prashant-shahi prashant-shahi requested a review from martinmr Jan 17, 2020
Copy link
Member Author

prashant-shahi left a comment

@MichaelJCompton I think even if this PR gets merged, it will only be available from docs.dgraph.io/master, and later from main docs if this commit gets picked for the new release.

But yeah, we can wait till the fork is replaced and other required docs are updated.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @martinmr, and @MichaelJCompton)

a discussion (no related file):
@sleto-it I placed it at first to go along with the usual alphabetical ordering.
Your suggestion sounds also right since Go client documentation is more elaborative that other clients cloud relate.



wiki/content/clients/index.md, line 61 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…
We also have [example](https://github.com/dgraph-io/Dgraph-dotnet/tree/master/source/Dgraph-dotnet.examples)
projects, which contains an working examples of how to use the C# client.

Suggestion for this sentence:

The [example](link to page) page contains working examples of how to use this client.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.