New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new script argument to docs #4746
Conversation
The user will be able to run like this ``` curl https://get.dgraph.io -sSf | bash -s -- --version=2.0.0-beta1 ``` or using Environment variables: ``` curl https://get.dgraph.io -sSf | VERSION=1.2.1 bash ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments but it
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai, @MichaelJCompton, @MichelDiz, and @sleto-it)
wiki/content/deploy/index.md, line 44 at r1 (raw file):
`-s | --systemd`: Automatically create Dgraph's installation as Systemd services. `-v | --version=2.0.0`: Choose Dgraph's version manually (you can do tag combinations e.g 2.0.0-beta1 or -rc1).
What's the default value for this? I am assuming it's the latest stable release but it should be stated so.
wiki/content/deploy/index.md, line 46 at r1 (raw file):
`-v | --version=2.0.0`: Choose Dgraph's version manually (you can do tag combinations e.g 2.0.0-beta1 or -rc1). Using Environment variables:
have a list of the environmental variables that are supported like we do for the arguments. I don't know if we only have one but it might change later. You can keep the example below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai, @martinmr, @MichaelJCompton, and @sleto-it)
wiki/content/deploy/index.md, line 44 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
What's the default value for this? I am assuming it's the latest stable release but it should be stated so.
Yes, it is the latest. I'll state this in the docs. Thanks for pointing it out.
wiki/content/deploy/index.md, line 46 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
have a list of the environmental variables that are supported like we do for the arguments. I don't know if we only have one but it might change later. You can keep the example below.
I gonna add more env vars. I have some plans to Systemd and OpenRC which involves the env variables. Just adding this, for now, just as a starting point in docs. But, as the PR wasn't merged, I can add those env vars in the same PR. And update this one.
* add new script argument to docs The user will be able to run like this ``` curl https://get.dgraph.io -sSf | bash -s -- --version=2.0.0-beta1 ``` or using Environment variables: ``` curl https://get.dgraph.io -sSf | VERSION=1.2.1 bash ``` * add more env variables * fix preffix * Add a warning
The user will be able to run like this
or using Environment variables:
fixes: #4730
This change is
Docs Preview: