Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "-k" to debug tool for encryption #5113

Merged
merged 3 commits into from Apr 7, 2020

Conversation

parasssh
Copy link
Contributor

@parasssh parasssh commented Apr 4, 2020

Description.

Add a new option "-k" to debug tool for encryption

GitHub Issue or Jira number.

https://dgraph.atlassian.net/browse/DGRAPH-1200

Other components or 3rd party tools affected (or regression areas).

Affected releases.

20.07

Changelog tags.

Added support for encryption in the debug tool.

Please indicate if this is a breaking change.

No.

Please indicate if this is an enterprise feature.

Yes.

Please indicate if documentation needs to be updated.

https://dgraph.atlassian.net/browse/DGRAPH-1202

Please indicate if end to end testing is needed.


This change is Reviewable

Docs Preview: Dgraph Preview

@parasssh parasssh requested review from manishrjain and a team as code owners April 4, 2020 20:07
dgraph/cmd/debug/run.go Outdated Show resolved Hide resolved
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @parasssh)

Copy link
Contributor Author

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @golangcibot from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@parasssh parasssh merged commit f38073a into master Apr 7, 2020
@parasssh parasssh deleted the paras/debug_enc_key_file branch April 7, 2020 04:58
parasssh pushed a commit that referenced this pull request Apr 8, 2020
parasssh pushed a commit that referenced this pull request Apr 9, 2020
parasssh pushed a commit that referenced this pull request Apr 9, 2020
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants