Check uid list is empty when filling shortest path vars. #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasssh
approved these changes
Apr 8, 2020
martinmr
added a commit
that referenced
this pull request
Apr 9, 2020
martinmr
added a commit
that referenced
this pull request
Apr 9, 2020
martinmr
added a commit
that referenced
this pull request
Apr 9, 2020
martinmr
added a commit
that referenced
this pull request
Apr 9, 2020
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description.
When filling the shortest path vars, the code checks the object is nil but
it doesn't check whether the uid list inside is empty, leading to out of bounds
errors.
GitHub Issue or Jira number.
https://dgraph.atlassian.net/browse/DGRAPH-1222
Affected releases.
20.03.1
Changelog tags.
fixed
Please indicate if this is a breaking change.
No
Please indicate if this is an enterprise feature.
No
Please indicate if documentation needs to be updated.
No
Please indicate if end to end testing is needed.
No
This change is