Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping floats that cannot be marshalled #5163

Merged
merged 12 commits into from Apr 14, 2020
Merged

Skipping floats that cannot be marshalled #5163

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c98bd22
Skipping floats that cannot be marshalled
gja Apr 10, 2020
abccf04
Switching to explictly skipping values
gja Apr 10, 2020
2b1ed4b
Splitting comments to two lines
gja Apr 10, 2020
f4c9222
Casting to float64
gja Apr 10, 2020
e287e1e
Merge remote-tracking branch 'origin/master' into tejas/skip-floats
gja Apr 11, 2020
f342771
WIP: Changing fastjson a bit
gja Apr 11, 2020
54df48e
Moving an if condition in query/outputnode.go
gja Apr 12, 2020
4c8944a
Switching to testing subgraph instead
gja Apr 13, 2020
0ca79b6
Adding documentation on how to use subgraph
gja Apr 13, 2020
56e29e0
Merge remote-tracking branch 'origin/master' into tejas/skip-floats
gja Apr 14, 2020
82e914e
Replaying some changes
gja Apr 14, 2020
0320cd6
Fixing things I screwed up in merge conflict
gja Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions query/outputnode.go
View file
Open in desktop
Expand Up @@ -20,6 +20,7 @@ import (
"bytes"
"encoding/json"
"fmt"
"math"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -251,6 +252,11 @@ func valToBytes(v types.Val) ([]byte, error) {
return []byte(fmt.Sprintf("%d", v.Value)), nil
}
case types.FloatID:
// +Inf, -Inf and NaN are not representable in JSON.
// Please see https://golang.org/src/encoding/json/encode.go?s=6458:6501#L573
if math.IsInf(v.Value.(float64), 0) || math.IsNaN(v.Value.(float64)) {
return nil, errors.New("Unsupported Inf or NaN in float field")
}
return []byte(fmt.Sprintf("%f", v.Value)), nil
case types.BoolID:
if v.Value.(bool) {
Expand Down