Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bulk-loader use-case to import unencrypted export and encrypt the result #5209

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

parasssh
Copy link
Contributor

@parasssh parasssh commented Apr 15, 2020

@parasssh parasssh requested review from manishrjain and a team as code owners April 15, 2020 00:01
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Got comments.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @parasssh)


dgraph/cmd/bulk/loader.go, line 120 at r1 (raw file):

		writeTs:       getWriteTimestamp(zero),
	}
	st.schema = newSchemaStore(readSchema(opt.SchemaFile, opt.BadgerKeyFile, opt.Encrypted), opt, st)

just pass in the opt object, instead of passing in individual arguments.


dgraph/cmd/bulk/run.go, line 109 at r1 (raw file):

			" The key size indicates the chosen AES encryption (AES-128/192/256 respectively). "+
			" This key is used to encrypt the output data directories and to decrypt the input "+
			" schema and data files (if enncrytped). Enterprise feature.")

if encrypted

Copy link
Contributor Author

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @manishrjain)


dgraph/cmd/bulk/loader.go, line 120 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

just pass in the opt object, instead of passing in individual arguments.

Done.


dgraph/cmd/bulk/run.go, line 109 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

if encrypted

Done.

Copy link
Contributor Author

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @manishrjain from 2 discussions.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)

@parasssh parasssh merged commit d982be3 into master Apr 15, 2020
parasssh pushed a commit that referenced this pull request Apr 15, 2020
… the result. (#5209)

Fixes DGRAPH-1254

(cherry-picked from commit d982be3)
parasssh pushed a commit that referenced this pull request Apr 15, 2020
parasssh pushed a commit that referenced this pull request Apr 15, 2020
… the result. (#5209) (#5213)

Fixes DGRAPH-1254
(cherry-picked from commit d982be3)
parasssh pushed a commit that referenced this pull request Apr 15, 2020
… the result. (#5209) (#5212)

Fixes DGRAPH-1254

(cherry-picked from commit d982be3)
@parasssh parasssh changed the title allow bulk-loader migration from unencrypted to encrypted Support bulk-loader use-case to import unencrypted export and encrypt the result Apr 15, 2020
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@joshua-goldstein joshua-goldstein deleted the paras/bulk_encrypted_flag branch August 11, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants