Online restores only processes backups for the alpha's group #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmr
changed the title
martinmr
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @vvbalaji-dgraph)
a discussion (no related file):
Thanks for the test. Could you also test it when we have more than one replica per group?
Changes lgtm:
vvbalaji-dgraph
approved these changes
Jun 9, 2020
martinmr
commented
Jun 9, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @vvbalaji-dgraph)
a discussion (no related file):
Previously, vvbalaji-dgraph (V V Balaji) wrote…
Thanks for the test. Could you also test it when we have more than one replica per group?
Changes lgtm:
Not a blocker for now so I'll address this later. Added a JIRA issue to track this.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
…io#5588) I changed the test backup to have three groups instead of one and I noticed that the test didn't work anymore. There was a missing check that caused every group's backup to be restored to the alpha. After introducing the check, all tests pass again. Fixes DGRAPH-1663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the test backup to have three groups instead of one and I noticed that
the test didn't work anymore. There was a missing check that caused every
group's backup to be restored to the alpha. After introducing the check, all
tests pass again.
Fixes DGRAPH-1663
This change is
Docs Preview: