Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readPostingList): Return error instead of panic #5877

Merged
merged 1 commit into from
Jul 9, 2020
Merged

fix(readPostingList): Return error instead of panic #5877

merged 1 commit into from
Jul 9, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Jul 8, 2020 •
edited by manishrjain
Loading

We've seen some panics like proto: illegal wireType 6 on trying to read the posting lists. We haven't found the fix yet. The issue could be because badger is returning incorrect values for the posting list. Since we haven't been able to reproduce it, this is a stop-gap solution to return an error instead of crashing dgraph. This is not the fix, this will return an error instead of causing a panic.

Fixes DGRAPH-1778

This change is Reviewable

martinmr
martinmr approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

ashish-goswami
ashish-goswami approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain and @martinmr)

parasssh
parasssh approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit f2773c8 into master Jul 9, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/protobuf-crash branch July 9, 2020 12:07
jarifibrahim pushed a commit that referenced this pull request Jul 9, 2020
fix(readPostingList): Return error instead of panic (#5877)
87e52af 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)
jarifibrahim pushed a commit that referenced this pull request Jul 9, 2020
fix(readPostingList): Return error instead of panic (#5877)
95d292c 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)
jarifibrahim pushed a commit that referenced this pull request Jul 9, 2020
fix(readPostingList): Return error instead of panic (#5877)
bc4d571 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)
parasssh pushed a commit that referenced this pull request Jul 13, 2020
fix(readPostingList): Return error instead of panic (#5877) (#5907)
9706b1e 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)
parasssh pushed a commit that referenced this pull request Jul 13, 2020
fix(readPostingList): Return error instead of panic (#5877) (#5908)
4e31555 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)

Co-authored-by: parasssh <paras@dgraph.io>
parasssh pushed a commit that referenced this pull request Jul 13, 2020
fix(readPostingList): Return error instead of panic (#5877) (#5906)
8e22f3b 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778

(cherry picked from commit f2773c8)

Co-authored-by: parasssh <paras@dgraph.io>
arijitAD pushed a commit that referenced this pull request Jul 14, 2020
fix(readPostingList): Return error instead of panic (#5877)
12968cb 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@dna2github
fix(readPostingList): Return error instead of panic (dgraph-io#5877)
c4b6b0e 
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.

This is not the fix, this will return an error instead of
causing a panic.

Fixes DGRAPH-1778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr approved these changes

@ashish-goswami ashish-goswami ashish-goswami approved these changes

@parasssh parasssh parasssh approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarifibrahim @martinmr @ashish-goswami @parasssh