fix (graphql): disallowing field names with as #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aman-bansal <bansalaman2905@gmail.com>
Signed-off-by: aman-bansal <bansalaman2905@gmail.com>
aman-bansal
requested review from
danielmai,
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
area/documentation
abhimanyusinghgaur
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @danielmai, @MichaelJCompton, and @pawanrawal)
pawanrawal
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danielmai and @MichaelJCompton)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to GRAPHQL-564. as is Dgraph reserved keyword. It's being used by DQL to identify variables. This PR is to restrict the naming for fields with the name as.
Though interesting things have been found while working on this. There is a difference in how we check as keyword while query parsing. For example, in normal DQL queries, the parser uses this strings.ToLower(peekIt[0].Val) == "as" (dgraph/gql/parser.go:2552) this means as, As, AS, aS all are the same.
But while parsing facets, its been treated like this !trySkipItemVal(it, "as") (dgraph/gql/parser.go:1984).
Though having a different use case, keyword significance is the same. Would love to hear thoughts about these implementations.
This change is
Docs Preview: