fix(dgraph): Fix empty string response for zero datetime (#6067) #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the empty string response for a zero-datetime value. The "0001-01-01T00:00:00Z" datetime is considered to be a zero value. Before we used to allow empty string for datetime mutation and internally stored empty string as zero datetime so we returned empty string for it but now empty string mutation is not allowed. So, we should return "0001-01-01T00:00:00Z" instead of empty string if the mutation contains "0001-01-01T00:00:00Z". (cherry picked from commit 386665f)
vmrajas
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
ahsanbarkati
approved these changes
Jan 4, 2021
danielmai
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @darkn3rd, @manishrjain, @pawanrawal, and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the empty string response for a zero-datetime value. The "0001-01-01T00:00:00Z" datetime is considered to be a zero value. Before we used to allow empty string for datetime mutation and internally stored empty string as zero datetime so we returned empty string for it but now empty string mutation is not allowed. So, we should return "0001-01-01T00:00:00Z" instead of empty string if the mutation contains "0001-01-01T00:00:00Z".
(cherry picked from commit 386665f)
Fixes DGRAPH-2859
This change is