Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calling Discard only adds to txn_discards metric, not txn_aborts. #7365

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Jan 25, 2021

This PR is a follow-up to #7339 to update the way dgraph_txn_discards_total and dgraph_txn_aborts_total are tracked. When the client calls Discard, only the dgraph_txn_discards_total metric is incremented, not dgraph_txn_aborts_total. This makes it easy to see:

  1. If the client is calling Discard
  2. If the server is aborting transactions (e.g., because of transaction conflicts)

This change is Reviewable

Copy link
Contributor

@karlmcguire karlmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

@danielmai danielmai merged commit 1bfb25a into master Jan 25, 2021
@danielmai danielmai deleted the danielmai/metrics-txn-discards branch January 25, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants