fix(backup): Fix perf issues with full backups #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change #7392 improved the incremental backups but degraded the performance of full backups. This PR fixes that. With this PR, we use the thread local iterator only for the incremental backups. Using the thread local iterator for full backups causes a 10x slowdown in performance.
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
aman-bansal
approved these changes
Feb 16, 2021
ahsanbarkati
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change #7392 improved
the incremental backups but degraded the performance of full backups.
This PR fixes that.
With this PR, we use the thread local iterator only for the incremental
backups. Using the thread local iterator for full backups causes a 10x
slowdown in performance.
Fixes - DGRAPH-3039
This change is