fix(live): fix live loader to load with force namespace #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
commented
Feb 17, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @vvbalaji-dgraph)
dgraph/cmd/live/run.go, line 680 at r1 (raw file):
// will be galaxy-wide. ctx = x.AttachGalaxyOperation(ctx, opt.namespaceToLoad) // We don't support upsert predicate while loading data in multiple namespace.
Add a test for this change.
ahsanbarkati
approved these changes
Feb 17, 2021
| @@ -284,6 +284,18 @@ func IsGalaxyOperation(ctx context.Context) bool { | |||
| return len(ns) > 0 && (ns[0] == "true" || ns[0] == "True") | |||
| } | |||
|
|
|||
| func GetForceNamespace(ctx context.Context) string { | |||
There was a problem hiding this comment.
Does this need to go into x?
jarifibrahim
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the live loader for loading data using
force-namespaceflag.Earlier, the schema alteration was not following the passed flag.
This change is