Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GraphQL): Apollo federation now works with lambda (GRAPHQL-1084) #7558

Merged
merged 8 commits into from
Mar 15, 2021
Merged

fix(GraphQL): Apollo federation now works with lambda (GRAPHQL-1084) #7558

merged 8 commits into from
Mar 15, 2021

Conversation

abhimanyusinghgaur
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur commented Mar 12, 2021 •
edited by manishrjain
Loading

This PR makes the @requires directive work with @custom/@lambda directives.

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Mar 12, 2021
@minhaj-shakeel minhaj-shakeel self-requested a review March 12, 2021 11:54
vmrajas
vmrajas approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@vmrajas vmrajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

graphql/schema/gqlschema_test.yml Outdated Show resolved Hide resolved
@abhimanyusinghgaur abhimanyusinghgaur merged commit cba5c5f into release/v21.03 Mar 15, 2021
@abhimanyusinghgaur abhimanyusinghgaur deleted the abhimanyu/custom-requires branch March 15, 2021 11:00
aman-bansal pushed a commit that referenced this pull request Mar 16, 2021
@abhimanyusinghgaur @aman-bansal
fix(GraphQL): Apollo federation now works with lambda (GRAPHQL-1084) (#…
a05f7f8 
…7558)

This PR makes the `@requires` directive work with `@custom/@lambda` directives.
@abhimanyusinghgaur abhimanyusinghgaur mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmrajas vmrajas vmrajas approved these changes

@minhaj-shakeel minhaj-shakeel minhaj-shakeel approved these changes

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abhimanyusinghgaur @vmrajas @minhaj-shakeel