Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v21.03 - perf(compression): Use gzip with BestSpeed in export and backup (#7643) #7683

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Apr 5, 2021

The export and backup code were using BestCompression and Default
gzip compression levels respectively. We see a 4x speed improvement when
switching from BestCompression to BestSpeed compression level.

(cherry picked from commit 5676462)


This change is Reviewable

The export and backup code were using BestCompression and Default
gzip compression levels respectively. We see a 4x speed improvement when
switching from BestCompression to BestSpeed compression level.

(cherry picked from commit 5676462)
Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be using snappy instead of gzip in backup. Anyways, it should be fine to make these incremental improvements in performance, in case the snappy one doesn't make it into release.

@jarifibrahim jarifibrahim merged commit f9d045a into release/v21.03 Apr 5, 2021
@jarifibrahim jarifibrahim deleted the ibrahim/r21.03-compression-perf branch April 5, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants