chore(contrib) - fixes for Vault #7739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/integrations
danielmai
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @darkn3rd)
danielmai
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Reviewable status:
|
|
mangalaman93
force-pushed
the
joaquin/vualt-fixes
branch
from
6bc5ccc
to
15877ad
Compare
mangalaman93
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
requested changes
Aug 12, 2023
mangalaman93
approved these changes
Aug 15, 2023
mangalaman93
force-pushed
the
joaquin/vualt-fixes
branch
from
15877ad
to
5af84ed
Compare
joshua-goldstein
approved these changes
Aug 15, 2023
| ```json | ||
| { | ||
| "options": { | ||
| "cas": 1 | ||
| }, | ||
| "data": { | ||
| "enc_key": "12345678901234567890123456789012", | ||
| "hmac_secret_file": "12345678901234567890123456789012" | ||
| "hmac_secret": "12345678901234567890123456789012" |
There was a problem hiding this comment.
are we sure of the key name change? In dgraph I still see using hmac_secret_file.
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
update formatting on multi-line JSON in curl commands
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
update formatting on multi-line JSON in curl commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes for spelling and correctness, update formatting on multi-line JSON in curl commands, tested the changes with new clean docker-compose vault environment.