Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-cloud: opt(dropPrefix): allow logical drop for deleting predicates and indexing (#7764) #7779

Merged
merged 2 commits into from
May 5, 2021
Merged

release-cloud: opt(dropPrefix): allow logical drop for deleting predicates and indexing (#7764) #7779

merged 2 commits into from
May 5, 2021

Commits on May 5, 2021

  1. opt(dropPrefix): allow logical drop for deleting predicates and index… 

    …ing (#7764)

Issue:
DropPrefix is Stop The World operation. It blocks the incoming writes. Dgraph uses this API at a couple of places like:
- drop data
- reindexing
- dropping predicate
The last 2 usages can lead to bad user impact in a multi-tenant cluster.

Solution:
This PR allows DropPrefix to use the blocking/non-blocking DropPrefix based on DB option `AllowStopTheWorld` that can be set using `--badger` superflag.

(cherry picked from commit c86b855)
    @NamanJain8
    NamanJain8 committed May 5, 2021
    Configuration menu
    Copy the full SHA
    20d199b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/release/v21.03-slash' into naman… 

    …/cp/drop-prefix
    @NamanJain8
    NamanJain8 committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4581741 View commit details
    Browse the repository at this point in the history