Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(log): better logging message for cleaning banned ns pred #7886

Merged
merged 1 commit into from Aug 16, 2023
Merged

chore(log): better logging message for cleaning banned ns pred #7886

merged 1 commit into from Aug 16, 2023

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Jun 4, 2021 •
edited by mangalaman93

No description provided.

@NamanJain8 NamanJain8 marked this pull request as draft June 4, 2021 13:26
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 changed the base branch from master to main August 11, 2023 03:16
@mangalaman93 mangalaman93 marked this pull request as ready for review August 11, 2023 03:17
darkn3rd
darkn3rd approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am surprised this was not in there.

@mangalaman93 mangalaman93 merged commit 2bd6569 into main Aug 16, 2023
22 checks passed
@mangalaman93 mangalaman93 deleted the naman/clean-banned branch August 16, 2023 07:53
jbhamra1 pushed a commit that referenced this pull request Aug 17, 2023
@NamanJain8 @mangalaman93 @jbhamra1
chore(raft): better logging message for cleaning banned ns pred (#7886)
6da8dca 
Co-authored-by: Aman Mangal <aman@dgraph.io>
jbhamra1 pushed a commit that referenced this pull request Aug 17, 2023
@NamanJain8 @mangalaman93 @jbhamra1
chore(raft): better logging message for cleaning banned ns pred (#7886)
033ab12 
Co-authored-by: Aman Mangal <aman@dgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nswamy nswamy nswamy approved these changes

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@darkn3rd darkn3rd darkn3rd approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

@mangalaman93 mangalaman93 Awaiting requested review from mangalaman93

@meghalims meghalims Awaiting requested review from meghalims

@sanjayk-github-dev sanjayk-github-dev Awaiting requested review from sanjayk-github-dev

@harshil-goel harshil-goel Awaiting requested review from harshil-goel

@billprovince billprovince Awaiting requested review from billprovince

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NamanJain8 @CLAassistant @nswamy @all-seeing-code @darkn3rd @mangalaman93