fix(conn): JoinCluster loop should use latest conn #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
pushed a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95)
danielmai
pushed a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95)
danielmai
pushed a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95)
danielmai
pushed a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95) (cherry picked from commit c4098ed)
danielmai
added a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95) Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai
added a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95) Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai
added a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95) Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai
added a commit
that referenced
this pull request
Jul 16, 2021
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy. This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue. (cherry picked from commit 7531e95) (cherry picked from commit c4098ed) Co-authored-by: Manish R Jain <manish@dgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.
This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.
This change is