adding bulk call for alpha to inform zero about the tablets #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
added a commit
that referenced
this pull request
Oct 26, 2021
* adding bulk call for alpha to inform zero about the tablets
aman-bansal
added a commit
that referenced
this pull request
Oct 26, 2021
) * adding bulk call for alpha to inform zero about the tablets (#8088)
NamanJain8
added a commit
that referenced
this pull request
Nov 30, 2021
… the tablets (#8… (#8100) * feat: adding bulk call for alpha to inform zero about the tablets (#8089) * adding bulk call for alpha to inform zero about the tablets (#8088) (cherry picked from commit c204d0a) * fix(zero): fix update membership to make bulk tablet proposal instead of multiple small (#8090) Converting the smaller tablet proposals into a single bulk call makes the execution faster. Else, this update becomes of the order of O(n^2), where n is the number of tablet updates. (cherry picked from commit 695c6d7) Co-authored-by: aman bansal <bansalaman2905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bulk API for zero so that alpha can inform about the predicates in a single go during the restart. This was needed for use cases where clients have 151k predicates and during the bulk loader zero was not started up. It was because alpha was sending the predicates one at a time and this turns into O(n^2) problem which never completes in a deterministic manner.
Hence we added an Inform API that alpha can send all the information in one single go to the zero and zero can initialize the node in one single go.
This change is