Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track context information of variables #821

Closed
wants to merge 5 commits into from
Closed

Conversation

ashwin95r
Copy link
Contributor

@ashwin95r ashwin95r commented Apr 10, 2017

This change is Reviewable

@manishrjain
Copy link
Contributor

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


query/query_test.go, line 432 at r1 (raw file):

			}

			me(id: var(sum), orderdesc: var(f)) {

add a few more tests, then submit.


Comments from Reviewable

@janardhan1993
Copy link
Contributor

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@ashwin95r
Copy link
Contributor Author

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.


query/query_test.go, line 432 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

add a few more tests, then submit.

Done.


Comments from Reviewable

@ashwin95r
Copy link
Contributor Author

Merged.

@ashwin95r ashwin95r closed this Apr 10, 2017
@pawanrawal pawanrawal deleted the track/var-context branch December 19, 2017 08:37
arijitAD pushed a commit that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants