Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): modify year in copyright #8385

Merged
merged 3 commits into from Nov 2, 2022
Merged

Conversation

skrdgraph
Copy link
Contributor

Problem

copyright version out of sync

Solution

change to 2022

@coveralls
Copy link

coveralls commented Oct 22, 2022

Coverage Status

Coverage remained the same at 37.18% when pulling bad7d2c on skrdgraph/copyright_2022 into c36206a on main.

ee/vault_ee.go Outdated Show resolved Hide resolved
graphql/e2e/custom_logic/custom_logic_test.go Outdated Show resolved Hide resolved
query/query0_test.go Outdated Show resolved Hide resolved
systest/ludicrous/run_test.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ skrdgraph
❌ Shreyasi


Shreyasi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@SashaDgraph SashaDgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me now. @skrdgraph please review.

@@ -117,7 +117,7 @@ func TestBackupMinio(t *testing.T) {
dirSetup(t)

// Send backup request.
// TODO: minio backup request fails when the environment is not ready,
// TODO: minio backup request fails when the environment is not ready,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SashaDgraph I guess this was missed in your checks, but it's okay (an extra space was cleaned up ~ possibly by your IDE)

@skrdgraph
Copy link
Contributor Author

👍 This PR looks good @SashaDgraph. I did a full review

@dshekhar95 - could you review this as well? This PR is touching 400+files, I did catch one small unrelated change - where I have left a comment. The best way to check the diff's is from your local IDE. We will wait for your review & then merge.

@dshekhar95 dshekhar95 self-requested a review November 2, 2022 20:49
Copy link
Contributor

@dshekhar95 dshekhar95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for reference, only file i saw with 2 changes was x/init.go

looks fine to me

@skrdgraph skrdgraph merged commit c04ce80 into main Nov 2, 2022
@skrdgraph skrdgraph deleted the skrdgraph/copyright_2022 branch November 2, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants