Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cd): adds arm job #8520

Merged
merged 4 commits into from
Dec 15, 2022
Merged

fix(cd): adds arm job #8520

merged 4 commits into from
Dec 15, 2022

Conversation

skrdgraph
Copy link
Contributor

@skrdgraph skrdgraph commented Dec 14, 2022 •
edited by adityasadalage
Loading

Problem

missing arm cd steps

Solution

change to manifests approach, and introduce arm build & push step

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Dec 14, 2022
@skrdgraph skrdgraph marked this pull request as ready for review December 15, 2022 22:34
meghalims
meghalims approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

adityasadalage
adityasadalage approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@adityasadalage adityasadalage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skrdgraph skrdgraph merged commit c6607af into main Dec 15, 2022
@skrdgraph skrdgraph deleted the skrdgraph/cd_arm branch December 15, 2022 22:55
@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasadalage adityasadalage adityasadalage approved these changes

@meghalims meghalims meghalims approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gajanan-dgraph gajanan-dgraph Awaiting requested review from gajanan-dgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects. dgraph Issue or PR created by an internal Dgraph contributor.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skrdgraph @adityasadalage @meghalims @MichelDiz