chore: fix flaky test TestGetAccessJwt #8818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
dgraph-bot
added
area/testing
| @@ -100,8 +99,10 @@ func TestGetAccessJwt(t *testing.T) { | |||
| {3456789012, "user3", []string{"702", "703"}}, | |||
| } | |||
|
|
|||
| worker.Config.AccessJwtTtl = 20 * time.Second | |||
There was a problem hiding this comment.
Do you think its a good idea to override it here instead of in config?
There was a problem hiding this comment.
This is a unit test. There is no config. This test does not talk to alpha or zero.
harshil-goel
approved these changes
May 6, 2023
all-seeing-code
approved these changes
May 6, 2023
jbhamra1
pushed a commit
that referenced
this pull request
May 9, 2023
This test does not talk to Alpha and requires setting up the TTL to 20 second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.