Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection health check when creating client #145

Closed
damienburke opened this issue May 18, 2020 · 2 comments · Fixed by #155
Closed

Connection health check when creating client #145

damienburke opened this issue May 18, 2020 · 2 comments · Fixed by #155
Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it

Comments

@damienburke
Copy link

Hi, I was wondering if there was a way to check if a connection to a Dgraph instance is available immediately after the dgraph4j client is setup. This way, I can check before hand if my first queries/mutations are going to fail.

dgraph-io/pydgraph#128 reported identical request and was "fixed" by exposing check_version call.
Thanks
@abhimanyusinghgaur
Copy link
Contributor

Thanks @damienburke,

We will look into it.

@abhimanyusinghgaur abhimanyusinghgaur added area/usability Issues with usability and error messages status/accepted We were able to reproduce the issue and accept to work on it kind/enhancement Something could be better. labels May 18, 2020
@minhaj-shakeel
Copy link
Contributor

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

drawing

@abhimanyusinghgaur abhimanyusinghgaur mentioned this issue Aug 6, 2020
Merged
abhimanyusinghgaur added a commit that referenced this issue Aug 7, 2020
@abhimanyusinghgaur
feat: Client now has a checkVersion method (#155)
8726bd9 
Fixes #145.
Fixes DGRAPH-1888.
This PR adds a `checkVersion()` method to both `DgraphClient` and `DgraphAsyncClient`. This method can be used to find out the version of Dgraph instance the client is interacting with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Client now has a checkVersion method dgraph-io/dgraph4j
3 participants
@damienburke @abhimanyusinghgaur @minhaj-shakeel