Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build scripts to support metadata #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented May 28, 2021

Currently dgraph-ratel -version binary does not report any metadata despite code support for metadata. This PR will do the following:

  • fix commitID and commitINFO that were set to empty strings
  • support passing in commitID, commitINFO, and version externally
  • support building building metadata version with docker and make.

Not Goals

The designated key names and value content have not been changed, using it as is. The metadata for commitINFO is bizarre, and I don't understand the original intention for this:

Ratel Version: v21.03.0-16-g5ec15c3
Commit ID: 9debcc4
Commit Info: 9debcc4¨•¨¨•¨Fri¨•¨May¨•¨28¨•¨14:57:46¨•¨2021¨•¨-0700¨•¨¨•¨¨•¨(HEAD¨•¨->¨•¨joaquin/build-meta-update,¨•¨origin/master,¨•¨origin/HEAD,¨•¨master)

This change is Reviewable

@darkn3rd darkn3rd requested review from MichelDiz and a team May 28, 2021 23:18
@darkn3rd darkn3rd requested a review from danielmai May 28, 2021 23:23
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants