tests: be a bit more explicit on initialization cases

dgraph-io · Jul 26, 2022 · 3f8b232 · 3f8b232
1 parent ff56594
commit 3f8b232
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/cache.go b/cache.go
@@ -277,7 +277,8 @@ func (c *Cache) SetIfPresent(key, value interface{}, cost int64) bool {
 }
 
 func (c *Cache) setInternal(key, value interface{},
-	cost int64, ttl time.Duration, onlyUpdate bool) bool {
+	cost int64, ttl time.Duration, onlyUpdate bool,
+) bool {
 	if c == nil || c.isClosed.Load() || key == nil {
 		return false
 	}

diff --git a/cache_test.go b/cache_test.go
@@ -120,28 +120,27 @@ func TestNewCache(t *testing.T) {
 	_, err := NewCache(&Config{
 		NumCounters: 0,
 	})
-	require.Error(t, err)
+	require.Error(t, err, "instantiating without explicit Config.MaxCost should fail")
 
 	_, err = NewCache(&Config{
 		NumCounters: 100,
 		MaxCost:     0,
 	})
-	require.Error(t, err)
+	require.Error(t, err, "instantiating with Config.MaxCost == 0 should fail")
 
 	_, err = NewCache(&Config{
-		NumCounters: 100,
-		MaxCost:     10,
-		BufferItems: 0,
+		MaxCost: 10,
 	})
-	require.NoError(t, err)
+	require.NoError(t, err, "instantiating with Config.MaxCost != 0 should not fail")
+	require.NotNil(t, c)
 
 	c, err := NewCache(&Config{
 		NumCounters: 100,
 		MaxCost:     10,
 		BufferItems: 64,
 		Metrics:     true,
 	})
-	require.NoError(t, err)
+	require.NoError(t, err, "instantiating with all explicit values should not fail")
 	require.NotNil(t, c)
 }