Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z: Add TotalSize method on bloom filter #197

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Sep 28, 2020

This PR adds a TotalSize function which returns the total size of the bloom filter.


This change is Reviewable

@jarifibrahim jarifibrahim changed the title z: Add totalSize method on bloom filter z: Add TotalSize method on bloom filter Sep 28, 2020
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anurags92, @jarifibrahim, @karlmcguire, and @manishrjain)


z/bbloom.go, line 136 at r1 (raw file):

len(bl.bitset)*8 + 5*8

maybe set this as constants. not clear what 5*8 represents.

@jarifibrahim jarifibrahim merged commit e1609c8 into master Sep 30, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/bfsize branch September 30, 2020 15:04
jarifibrahim pushed a commit to dgraph-io/badger that referenced this pull request Oct 3, 2020
This PR depends upon dgraph-io/ristretto#197
`badger info` now shows index size and bloom filter size
manishrjain pushed a commit to outcaste-io/outserv that referenced this pull request Jul 6, 2022
This PR depends upon dgraph-io/ristretto#197
`badger info` now shows index size and bloom filter size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants