fix(z): Address inconsistent mremap return arguments with arm64 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcneely
requested review from
akon-dey,
gajanan-dgraph,
joshua-goldstein and
skrdgraph
as code owners
joshua-goldstein
deleted the
matthewmcneely/create-cpu-specific-linux-mremap-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specific arm64 implementation for the
mremapfunction which ignores the second return argument from the syscall. All other Linux implementations are unchanged.This PR reworks an earlier PR so that the functionality on non-arm64 platforms remains the same.
Tested on Linux amd64 and Linux arm64.